[interpreter] add new assertions for custom sections

WebAssembly / annotations

Proposal for Custom Annotation Syntax in the Text Format

https://WebAssembly.github.io/annotations/

Other

19 stars 10 forks source link

Closed yuri91 closed 8 months ago

yuri91 commented 1 year ago

assert_malformed and assert_invalid now have a _custom variant, for asserting custom section/annotation errors.

The js implementation is a no-op, since no JS engine currently support any kind of diagnostic for custom sections.

rossberg commented 1 year ago

PS: I believe you need to extend harness/testharness.js with the new assertions as well.

yuri91 commented 1 year ago

Ah right, I missed that. I added them but I am not sure how to test that it works.

rossberg commented 1 year ago

Me neither, to be honest. :)

yuri91 commented 11 months ago

@rossberg is testing the harness changes a blocker for merging this? If so I can try to figure out how to do it

rossberg commented 10 months ago

(Sorry for the delay, was on a break.)

I'm fine with merging.

yuri91 commented 8 months ago

@rossberg could you merge this?

rossberg commented 8 months ago

Oh, sure! Sorry.

yuri91 commented 8 months ago

thanks!