WebAssembly / annotations

Proposal for Custom Annotation Syntax in the Text Format
https://WebAssembly.github.io/annotations/
Other
20 stars 11 forks source link

Test assert grammar works, but grammar doesn't fit into current specification #6

Closed alexcrichton closed 4 years ago

alexcrichton commented 4 years ago

Currently there's a test in this repository that the following parses:

(@a Heiße Würstchen   

)

(pulled from here)

but according to the current proposed text:

annot ::= "(@"idchar+  annotelem* ")"
annotelem ::= keyword | reserved | uN | sN | fN | string | id | "(" annotelem* ")" | "(@"idchar+ annotelem* ")"

I don't think any of these can afford for non-ascii characters such as Heiße. Is it intended that the spec should be updated or should the test case here be dropped?

rossberg commented 4 years ago

Indeed, test was nonsense. Removed.

alexcrichton commented 4 years ago

Thanks for the quick fix!