WebAssembly / component-model

Repository for design and specification of the Component Model
Other
933 stars 79 forks source link

Update WIT and binary import/export syntax #198

Closed alexcrichton closed 1 year ago

alexcrichton commented 1 year ago

This is an update to WIT.md and a minor update to Binary.md to reflect the changes discussed in #193. Lots more discussion is in the issue, and a summary of the changes is:

alexcrichton commented 1 year ago

I'll also note that I'm in the process of implementing these changes. Current work is:

guybedford commented 1 year ago

With regards to the ESM integration, it would be great to handle this in this PR as well since those behaviours do need to be worked out as part of this. My suggestion would be a note along the lines of the following bullet points:

alexcrichton commented 1 year ago

Ok I'm going to go ahead and merge this, if at least to have the current spec reflect what's implemented now in tooling. I talked with @lukewagner and he'll update Explainer.md shortly afterwards and I think any further minor updates can happen in subsequent PRs. Thanks all for the discussion here!

guybedford commented 1 year ago

@alexcrichton if I had known that the ESM integration upgrade wasn't going to be made in this PR I likely wouldn't have approved it. There are not "further minor updates" but fundamental details of the model that we cannot ignore.

lukewagner commented 1 year ago

ESM-integration updates aren't "minor", but I do think this and other language integrations questions can be done as follow-ups without changing what's in the AST and binary, so it's a good idea to merge now and iterate forward. I'll be working to update some other parts of Explainer.md shortly.