WebAssembly / component-model

Repository for design and specification of the Component Model

Other

933 stars 79 forks source link

fix: ESM integration notes for latest binary changes #204

Closed guybedford closed 1 year ago

guybedford commented 1 year ago

Adds the omitted ESM integration update for https://github.com/WebAssembly/component-model/pull/198.

alexcrichton commented 1 year ago

Oh apologies for jumping the gun! I wasn't thinking that the Explainer.md was entirely sorted out though as I hadn't touched it at all just yet. @lukewagner should be working on more expansive changes to Explainer.md, but otherwise this looks good to me too 👍

guybedford commented 1 year ago

Thanks for clarifying, was just a bit surprised to see it not being addressed after my comment, completely understood that PR had been stood open a while and the need to move forward now as well.

lukewagner commented 1 year ago

205 I believe subsumes this PR, marking the particular paragraph as a "TODO".

guybedford commented 1 year ago

Thanks, that covers it fine as well for now.