WebAssembly / component-model

Repository for design and specification of the Component Model
Other
933 stars 79 forks source link

Handle class was renamed to HandleElem but not all references were updated #216

Closed patrickhuber closed 1 year ago

patrickhuber commented 1 year ago

I think commit 05cef2e changed the Handle class to HandleElem but not all references were updated.

I noticed that even with this change, the CI still passed. Is there enough code coverage to ensure this would have been caught?

lukewagner commented 1 year ago

Thanks! At the moment, mostly b/c I'm a Python n00b, we're not running Python in the type-checking mode, so all the type annotations are purely documentative atm.

patrickhuber commented 1 year ago

Could you also make the same change in CanonicalABI.md?

Yes, one moment

patrickhuber commented 1 year ago

Done

lukewagner commented 1 year ago

Thanks!