WebAssembly / component-model

Repository for design and specification of the Component Model
Other
914 stars 78 forks source link

Use semicolons as delimiters in WIT text format #249

Closed alexcrichton closed 10 months ago

alexcrichton commented 10 months ago

This commit commit is an implementation of #142 where semicolons are now required as delimiters between items in the WIT text format. All items in the WIT format are now delimited with either curly braces ({}) or semicolons except for the package statement where it subjectively felt a bit weird to require a semicolon. I've updated the various examples in WIT.md as an example of the new syntax.

My plan on implementing this would be along the lines of:

The hope is to create a period of time where both syntax forms are accepted. This provides a transitionary means from one syntax to the other while proposals are updated. This transitionary period is finite in length, however.

Closes #142

alexcrichton commented 10 months ago

I've got a PR for an implementation of this when it's ready at https://github.com/bytecodealliance/wasm-tools/pull/1212 which can also serve as a means to evaluate the aesthetics of the change via reading all the changes to tests. (aesthetics improved IMO)

lukewagner commented 10 months ago

Looks like no disagreement, so merging.