Reserve handle index 0 and add handle index max in Canonical ABI

WebAssembly / component-model

Repository for design and specification of the Component Model

Other

899 stars 75 forks source link

Reserve handle index 0 and add handle index max in Canonical ABI #284

Closed lukewagner closed 7 months ago

lukewagner commented 7 months ago

As discussed in #282. In theory, this shouldn't be breaking since guest code shouldn't be depending on the precise index values they receive, treating them like opaque file-descriptor-like values.

alexcrichton commented 7 months ago

I've posted https://github.com/bytecodealliance/wasmtime/pull/7661 as the Wasmtime-side implementation change this correponds to

lukewagner commented 7 months ago

Great! I'm thinking I'll wait another few days to see if there's any feedback and otherwise merge mid next week.