search

WebAssembly / component-model

Repository for design and specification of the Component Model
Other
946 stars 79 forks source link

Minor issue in definiitons.py #318

Closed GordonSmith closed 6 months ago

GordonSmith commented 6 months ago

Just looking at: https://github.com/WebAssembly/component-model/blob/main/design/mvp/canonical-abi/definitions.py#L405-L406

case Own()          : return lift_own(cx, load_int(cx.opts, ptr, 4), t)
case Borrow()       : return lift_borrow(cx, load_int(cx.opts, ptr, 4), t)

Looks like it should be:

case Own()          : return lift_own(cx, load_int(cx, ptr, 4), t)
case Borrow()       : return lift_borrow(cx, load_int(cx, ptr, 4), t)
lukewagner commented 6 months ago

(Sorry for the slow reply) You're right; fixed

lukewagner commented 6 months ago

Also: thanks!