WebAssembly / exception-handling

Proposal to add exception handling to WebAssembly
https://webassembly.github.io/exception-handling/
Other
162 stars 35 forks source link

Issues with the README #310

Closed 7ombie closed 5 months ago

7ombie commented 5 months ago

The README says this:

In case of catch or catch_ref, the arguments of the exception are pushed back onto the stack. For catch_ref and catch_all_ref, an exception reference is then pushed to the stack, which represents the caught exception.

I may be wrong, but this just seemed inconsistent. I would assume it should say this:

In case of catch or catch_all, the arguments of the exception are pushed back onto the stack. For catch_ref and catch_all_ref, an exception reference is then pushed to the stack, which represents the caught exception.

There's also a minor typo in the following line (it misspells caught as cought):

All forms have a label which is branched to when an exception is cought (see below).

I didn't want to become a "contributor" for such a trivial pull request, so just opened an issue here instead.

sjrd commented 5 months ago

I may be wrong, but this just seemed inconsistent. I would assume it should say this:

The readme is correct on that point. The non-_all variants push the arguments. The _ref variants push a ref. Therefore:

aheejin commented 5 months ago

Please ignore the previous comment (now deleted) of mine here; I was confused and posted some incorrect info.

7ombie commented 4 months ago

No worries, @aheejin. Glad it's all correct, either way. Sorry for any noise on my part.