Closed 7ombie closed 5 months ago
I may be wrong, but this just seemed inconsistent. I would assume it should say this:
The readme is correct on that point. The non-_all
variants push the arguments. The _ref
variants push a ref. Therefore:
catch_all
: nothing on the stackcatch
: the arguments on the stackcatch_all_ref
: the ref on the stackcatch_ref
: the arguments and the ref on the stackPlease ignore the previous comment (now deleted) of mine here; I was confused and posted some incorrect info.
No worries, @aheejin. Glad it's all correct, either way. Sorry for any noise on my part.
The README says this:
I may be wrong, but this just seemed inconsistent. I would assume it should say this:
There's also a minor typo in the following line (it misspells caught as cought):
I didn't want to become a "contributor" for such a trivial pull request, so just opened an issue here instead.