search

WebAssembly / gc

Branch of the spec repo scoped to discussion of GC integration in WebAssembly
https://webassembly.github.io/gc/
Other
997 stars 72 forks source link

[test] Add boundary cast tests for ToWebAssemblyValue #439

Closed takikawa closed 1 year ago

takikawa commented 1 year ago

This PR adds JS API tests for exercising ToWebAssemblyValue with all the categories of GC types. It adds on top of the previous two JS API tests PRs, so it should be merged after them (just the last commit is new).

With these three tests, I think we will have good test coverage of the JS API, but if anyone sees any missing cases that should be covered that would be helpful to know.

The tests pass on JSC (w/ some unlanded patches), V8, and SpiderMonkey (w/ final opcodes) with one exception that I'll comment below.

takikawa commented 1 year ago

I'm going to be out of office for two weeks but if anyone has feedback about this or any of the other JS API PRs I can take a look and address them once I'm back.

takikawa commented 1 year ago

@rossberg I think the latest commit should address your comments.

There are merge conflicts but I can rebase to fix once the PR looks ok.

takikawa commented 1 year ago

This is now rebased and should merge cleanly.