search

WebAssembly / gc

Branch of the spec repo scoped to discussion of GC integration in WebAssembly
https://webassembly.github.io/gc/
Other
997 stars 72 forks source link

remove duplicated token definition in parser #474

Closed zapashcanon closed 11 months ago

zapashcanon commented 11 months ago

It is already defined two lines above. This was introduced in #422.

ocamlyacc doesn't produce an error in these cases, but it probably should. I opened an issue upstream .

I tried on the Owi interpreter where I'm using Menhir and it is producing an error when this is the case: Error: the token REF_I31 has multiple definitions..

It would be nice to switch to Menhir at some point (which is the standard in OCaml nowadays) but I guess introducing one more dependency is not acceptable ?

zapashcanon commented 11 months ago

Thanks for merging @rossberg. What are your thoughts about switching to Menhir ? As stated in the issue linked above, ocamlyacc is almost considered as deprecated. I'm willing to send a PR if we can accept Menhir as a dependency.

rossberg commented 11 months ago

I'd be fine with it.