WebAssembly / gc

Branch of the spec repo scoped to discussion of GC integration in WebAssembly
https://webassembly.github.io/gc/
Other
982 stars 70 forks source link

Add a test for #516 to the test suite #518

Closed fitzgen closed 7 months ago

fitzgen commented 7 months ago

r? @rossberg

fitzgen commented 7 months ago

There isn't a br_on_null.wast in the gc directory. Should I create one?

rossberg commented 7 months ago

It's in the main directory. But you'll need to modify the example to avoid the use of GC features (which should be inessential to the issue). E.g. with some use of subtyping that works with just the funcref proposal.

fitzgen commented 7 months ago

@rossberg rewrote it to use (ref null $ty) and funcref instead of structref and anyref and moved the test into br_on_null.wast.