search

WebAssembly / interface-types

Other
642 stars 57 forks source link

Binary encoding of webIDL #22

Closed fgmccabe closed 5 years ago

fgmccabe commented 5 years ago

This is a draft of a spec for encoding webIDL in a binary format. To be viewed as an adjunct to the eventual spec for host bindings

littledan commented 5 years ago

Cc @ms2ger

binji commented 5 years ago

It's hard to see where this differs from #21. Can you make your changes a PR against the refresh branch so it's easier to diff?

fgmccabe commented 5 years ago

will do. my klutziness I guess

On Thu, Apr 4, 2019 at 12:31 PM Ben Smith notifications@github.com wrote:

It's hard to see where this differs from #21 https://github.com/WebAssembly/host-bindings/pull/21. Can you make your changes a PR against the refresh branch so it's easier to diff?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WebAssembly/host-bindings/pull/22#issuecomment-480032883, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAL0DBU9fkiOpS5E-3Ju_iunG6hgytiks5vdlMqgaJpZM4cblLW .

-- Francis McCabe SWE

lukewagner commented 5 years ago

I can't reconstruct how, but somehow me merging #21 merged this PR too? Anyhow, now we have proposals/host-bindings/binding.bs and everything else in proposals/webidl-bindings.

fgmccabe commented 5 years ago

Yes I messed something up. TBH that was my fit ever pr

On Thu, Apr 4, 2019 at 5:49 PM Luke Wagner notifications@github.com wrote:

I can't reconstruct how, but somehow me merging #21 https://github.com/WebAssembly/webidl-bindings/pull/21 merged this PR too? Anyhow, now we have proposals/host-bindings/binding.bs and everything else in proposals/webidl-bindings.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WebAssembly/webidl-bindings/pull/22#issuecomment-480112575, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAL0KvtO1pK7TxxDyzRp_cZWmYmTOtEks5vdp2ngaJpZM4cblLW .

-- Francis McCabe SWE

lukewagner commented 5 years ago

No worries, it's definitely confusing when starting out. Maybe create a new PR that just moves binding.bs to the webidl-bindings subdir and we can use that one to discuss?