Closed fgmccabe closed 4 years ago
I imagine that the review request sent to me was for somebody else. Maybe @binji ?
It was sent to you because github recommended it. Feel free to ignore or review 😀
On Mon, Jan 13, 2020 at 2:10 AM Benjamin Bouvier notifications@github.com wrote:
I imagine that the review request sent to me was for somebody else. Maybe @binji https://github.com/binji ?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WebAssembly/interface-types/pull/93?email_source=notifications&email_token=AAQAXUFZGQJRC252VLWNFYTQ5Q4YHA5CNFSM4KFL3UP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIYERGQ#issuecomment-573589658, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQAXUHRUFFHI4LZA3OXHUDQ5Q4YHANCNFSM4KFL3UPQ .
-- Francis McCabe SWE
I like the new structure! At this point everything looks pretty good to me, other than the section on nominal types (see my comment there from last time).
The latest revision looks really solid to me; especially found the refactoring of the intro to be merged into the "WebIDL" section to get the essay's argument across succinctly and clearly. From my point of view this is ready to land.
Draft of a 'choices note' explaining the relationship between Interface Types and WebIDL.