WebAssembly / js-string-builtins

JS String Builtins
Other
8 stars 6 forks source link

Web Platform Tests #33

Closed ecmziegler closed 1 month ago

ecmziegler commented 3 months ago

Are there any plans on adding Web Platform Tests for this proposal? Because it defines a JS-observable behavior, it might make sense to add these like we did for other proposals in the past. At least we could add a test to check if WebAssembly.instantiate() succeeds or fails when called on a module which uses the implicit function/constants imports and if the exposed objects have the correct types.

Adding functional tests for the implicit functions and if they do the right thing might not be necessary, because this should be well covered by Wasm tests.

eqrion commented 3 months ago

I did add tests locally to this repo. It'd probably be good to get that in WPT.

eqrion commented 1 month ago

I added two more tests into this repo, and then I'm landing a commit which will get all of these tests into WPT.