JS API changes? - Githubissues

WebAssembly / memory64

Memory with 64-bit indexes

Other

194 stars 21 forks source link

JS API changes? #24

Closed lars-t-hansen closed 11 months ago

lars-t-hansen commented 2 years ago

This proposal looks like it might need changes to the JS API, off the top of my head at least these:

the index type needs to be described in the memory descriptor (our prototype uses the key "index" for this)
the current JS API enforces the range of initial and max to be unsigned long, ie, a u32, but this proposal requires something better than that

aardappel commented 2 years ago

Not familiar with the JS API design myself.. @backes did you run into this?

backes commented 2 years ago

I didn't hit this yet, but the V8 implementation is not complete yet. Also, we currently still only allow up to 4GB memories, even if you use 64 bit for indexing.

But I agree that the JS API will need changes.

sbc100 commented 1 year ago

@lars-t-hansen what do you propose for the value of "index"? The string u64 or u32 maybe?

eqrion commented 1 year ago

SpiderMonkey currently uses “i32” and “i64” for the JS-type representation of index type. IIRC, that’s what the memory64 proposal uses in the text format, so we were trying to stay symmetrical to that.

On Aug 19, 2022, at 9:16 AM, Sam Clegg @.***> wrote:

@lars-t-hansen what do you propose for the value of "index"? The string u64 or u32 maybe?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

sbc100 commented 11 months ago

I believe this is fixed by #39