search

WebAssembly / memory64

Memory with 64-bit indexes
Other
194 stars 21 forks source link

`call_indirect` reserved byte in binary tests #32

Closed adambratschikaye closed 4 months ago

adambratschikaye commented 1 year ago

It looks like some of the tests in binary.wast are checking that the table index to call_indirect instructions is 0x00: https://github.com/WebAssembly/memory64/blob/d0fbbe7b1d3c2cabf8409a48f70c94956ebfbe7f/test/core/binary.wast#L69 But that doesn't seem to be required in the spec. Is that just left over from an older version?

titzer commented 1 year ago

Indeed, that seems to be leftover from days before bulk-memory landed.

sbc100 commented 4 months ago

I think this can be closed now since this proposal now up-to-date with the upstream spec and now includes 7fa2f20a6df4cf1c114582c8cb60f5bfcdbf1be1 which removed the line in question.

adambratschikaye commented 4 months ago

Thanks @sbc100