search

WebAssembly / memory64

Memory with 64-bit indexes
Other
194 stars 21 forks source link

Fix error in type of memory.init introduced in #56 #57

Closed sbc100 closed 1 month ago

sbc100 commented 1 month ago

Sorry for the churn. This time I'll double check the test in wabt before updating the testsuite repo.

dschuff commented 1 month ago

Should the size and offset fields of memory.init not be the same size as pointers, a la size_t?

sbc100 commented 1 month ago

Those arguments are supposed to stay as i32.. at least according the overview and current implementations.

bvisness commented 1 month ago

I think it makes sense for these parameters to remain i32 since they are determined by the data segment, which still doesn't use 64-bit indices. (Nor should it, probably.)

dschuff commented 1 month ago

Ah, right. I guess that logic would make more sense for memory.copy than memory.init.