(Bikeshed) Should we rename the parameters for `Table.get` and `Table.set`?

WebAssembly / memory64

Memory with 64-bit indexes

Other

225 stars 21 forks source link

(Bikeshed) Should we rename the parameters for `Table.get` and `Table.set`? #93

Open bvisness opened 3 days ago

bvisness commented 3 days ago

@backes points out in this comment that perhaps we should rename the index parameter on Table.get and Table.set to address as a result of #67. I'm not sure we want to, since the existing spec already uses the term "index" and it's quite clear in context that it's referring to the index of an element. Thoughts? (This certainly does not need to block phase 4 vote imo. Just wanted to discuss it before it all ends up on MDN and wherever else.)

backes commented 3 days ago

It's obviously not super critical, but while we change the type from unsigned long to AddressValue I would prefer to also just rename index to address, for consistency.