WebAssembly / relaxed-simd

Relax the strict determinism requirements of SIMD operations.
Other
43 stars 9 forks source link

Discrepancy between overview's dot product instructions and tests #117

Closed alexcrichton closed 1 year ago

alexcrichton commented 1 year ago

Currently in the overview two dot product instructions are specified:

but in the tests the names of the instructions drop the relaxed_ prefix on the instruction name and additionally still have f32x4.relaxed_dot_bf16x8_add_f32x4 as an instruction to test. Was the f32x4 instruction removed from the proposal and forgotten to have tests removed? Or the other way around where it was added but not added to the overview?

Maratyszcza commented 1 year ago

f32x4.relaxed_dot_bf16x8_add_f32x4 was removed. relaxed_ was added to all instruction names, but probably this change missed the tests.

ngzhian commented 1 year ago

This is now fixed.