search

WebAssembly / simd

Branch of the spec repo scoped to discussion of SIMD in WebAssembly
Other
531 stars 43 forks source link

[spectext] Add i64x2 eq,ne,lt_s,gt_s,le_s,ge_s. #455

Closed ngzhian closed 3 years ago

ngzhian commented 3 years ago

Previously it was included \ishape.\virelop, but it is incorrect, as we don't have i64x2 unsigned comparisons.

i64x2 unsigned comparisons were added in #412.

rossberg commented 3 years ago

Hm, I wonder if some of the irregularity wouldn't be more readable with grammar side conditions that blacklist the exceptions, instead of listing all allowed cases.

ngzhian commented 3 years ago

Oh dear, the arbitrariness in the instruction matrix is starting to drive me insane...

Yea, the lowerings for i64x2 unsigned comparisons is not good enough to meet acceptance criteria, and is only better on hardware that isn't widely available yet.

Hm, I wonder if some of the irregularity wouldn't be more readable with grammar side conditions that blacklist the exceptions, instead of listing all allowed cases.

I can try to come up with some restrictions on the grammar, not sure how I would phrase it. Let me finish adding all the instructions to syntax then we can explore this, I'll file a TODO on myself.