search

WebAssembly / spec

WebAssembly specification, reference interpreter, and test suite.
https://webassembly.github.io/spec/
Other
3.11k stars 439 forks source link

[spec] Refactor the prose-form specification #1629

Closed f52985 closed 1 year ago

f52985 commented 1 year ago

This pull request refactors the prose-form specification for execution of instructions. It is mainly refactored to be more consistent in style, and some minor issues are fixed.

rossberg commented 1 year ago

Hi @f52985, can you please undo your force-pushes, revert to the commit that I reviewed, and then push the new changes as regular commits? For a change this big, it is impossible to tell the relative diffs otherwise.

As a general rule, never force-push to a PR branch, since that completely breaks the code review workflow. ;)

f52985 commented 1 year ago

Hello @rossberg,

Sorry for making the force-pushes, which made the review history too confusing.

It seems a bit misleading, but the original commits that contain the comments are untouched. There is already a single commit(ae9e0b8) (which itself was forced-puhsed) that contains every new changes based on the comments, on top of the latest reviewed commit(93801ec).

rossberg commented 1 year ago

Okay, thanks!