search

WebAssembly / spec

WebAssembly specification, reference interpreter, and test suite.
https://webassembly.github.io/spec/
Other
3.09k stars 438 forks source link

[interpreter] Update Makefile to ignore output of `cd` #1683

Closed tlively closed 9 months ago

tlively commented 9 months ago

The interpreter Makefile captures the output of cding into the unittest directory and listing the unittest files it contains. Under some circumstances, the cd command will print the new current directory, and that output was incorrectly being interpreted as the path to a unittest, causing the build to fail.

Fix this problem by redirecting the output of cd, if any, to /dev/null.

Fixes #1681.

tlively commented 9 months ago

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

rossberg commented 9 months ago

Oh, you might wanna do the same for TESTFILES.

tlively commented 9 months ago

done, thanks