WebAssembly / spec

WebAssembly specification, reference interpreter, and test suite.
https://webassembly.github.io/spec/
Other
3.13k stars 445 forks source link

[test] introduce script scopes around expensive memory tests #1699

Open rossberg opened 11 months ago

rossberg commented 11 months ago

Fix #1698. This tweaks the generators for bulk memory/table tests to insert (script ...) scopes around tests and extends the JS converter to turn these into block scopes.

This is likely to break existing .wast consumers that do not recognise script scopes. The simplest fix is to ignore them by treating them as equivalent to their contents.

titzer commented 11 months ago

Does it help to split up these tests into multiple .wasts? In general, splitting up the many large spec tests helps ergonomics of the test suite.

rossberg commented 11 months ago

Personally, I'm not a big fan of having a gazillion micro test files. But in any case, these are generated, so that would require a more significant rewrite of the JS generator scripts, that somebody would have to volunteer doing.