search

WebAssembly / spec

WebAssembly specification, reference interpreter, and test suite.
https://webassembly.github.io/spec/
Other
3.09k stars 438 forks source link

[JS API] 'run a host function' and 'create a host function' don't consistently handle completion records #1743

Open dschuff opened 2 months ago

dschuff commented 2 months ago

The algorithm for run a host function uses ReturnIfAbrupt ([=?=]) when calling the underlying JS function (meaning it can just return the completion record), or otherwise returns the result value(s) converted with ToWebAssemblyValue. But 'create a host function' just treats its result value as a completion record when it asserts that the type is normal or throw and returns result.Value. Maybe 'run a host function' should just convert the JS results to WebAssembly values as it does now and put them back into result.Value, and return the whole completion record.

I noticed this while while working on https://github.com/WebAssembly/exception-handling/pull/301 which changes some of this code. We could just fix the issue there, which would simplify merging the EH proposal into the spec. Or we could fix it in both places.

Ms2ger commented 2 months ago

Agree that some clarification could be helpful here. Generally outside of JS and prose that interfaces with it closely, notably when using WebIDL, we use the infra convention. Not sure where we might switch between the conventions.