search

WebAssembly / stack-switching

A repository for the stack switching proposal.
Other
134 stars 13 forks source link

Spec testsuite #80

Open dhil opened 2 weeks ago

dhil commented 2 weeks ago

We should develop the spec testsuite for the stack switching proposal. I have something implemented already in https://github.com/WebAssembly/stack-switching/blob/wasmfx/test/core/cont.wast, however it currently lacks tests for switch and it does not thoroughly test interactions with other proposals (exception handling and gc would be of particular interest, I think).

rossberg commented 2 weeks ago

Good idea. We should structure it along the lines of other proposals, i.e., a cont/ (or stack/) subdirectory, and separate wast files per instruction tested, where possible.

frank-emrich commented 2 weeks ago

Do the tests for other proposals usually separate the tests for validation from those for execution in some way? We do have some tests that attempt to cover every aspect of the validation of wasmfx instructions here and here.

I'm happy to split these into per-instruction files, but I'm wondering about the file structure beyond that. For example, the existing file structure makes sure that everything depending on GC lives in its own file, so we can use these files to also use these tests on engines that don't implement GC yet.

rossberg commented 2 weeks ago

So far, validation and execution isn't split anywhere.