Closed dhil closed 2 months ago
~Perhaps add this as a test case?~
Sorry, strike that, makes no sense.
~Perhaps add this as a test case?~
Sorry, strike that, makes no sense.
Exactly. I realised this myself when the testsuite kept failing, despite the fix being correct :-))
~Perhaps add this as a test case?~ Sorry, strike that, makes no sense.
Exactly. I realised this myself when the testsuite kept failing, despite the fix being correct :-))
Can you just add an assert_trap
to this test?
~Perhaps add this as a test case?~ Sorry, strike that, makes no sense.
Exactly. I realised this myself when the testsuite kept failing, despite the fix being correct :-))
Can you just add an
assert_trap
to this test?
Not as it is now. It would count as a "failure", as the exception Eval.Suspension
is caught outside the Wast directive driver. So, the Wast driver is exited, meaning no further tests are run.
Same thing happens for Wasm exceptions, e.g.
(module
(type $f1 (func))
(tag $e)
(func (export "main")
(throw $e)
)
)
(assert_trap (invoke "main") "uncaught exception")
This program fails in a similar manner as it does not pass the trap assertion.
Same thing happens for Wasm exceptions, e.g.
(assert_trap (invoke "main") "uncaught exception")
This program fails in a similar manner as it does not pass the trap assertion.
Got it, thanks. So the test should have an assert_suspension
This patch fixes #92 such that the interpreter exits gracefully on an unhandled tag.