Open Liedtke opened 1 year ago
Shouldn't this be returning ref string
instead?
@Liedtke @jakobkummerow
BTW, I think also binaryen mismatches Chrome here and assumes the instruction returns ref string
which results in code rejected by V8. Adding @kripken to verify.
@gkdn Yeah, the returned value is never null. I'll adapt the return type in v8 and in my comment above.
What should happen for invalid code points? Like 0x110000
and above. In JavaScript this leads to an exception. At least for String.fromCodePoint
@MaxGraey The instruction traps for invalid codepoints.
@Liedtke do you have link to the dashboard to track the release? or if you know dev-channel version to get the fix that would work as well.
@gkdn It's in Dev 112.0.5612, see https://chromiumdash.appspot.com/commit/54b016989406901e819d3090a92739e7bc1c98b9.
Following up on https://github.com/WebAssembly/stringref/issues/5#issuecomment-1312572737 we decided to implement
string.from_code_point
for performance evaluations in V8 (see also #58):string.from_code_point(codepoint: i32) -> ref string
, opcode0xfba9