search

WebAssembly / tool-conventions

Conventions supporting interoperatibility between tools working with WebAssembly.
Artistic License 2.0
297 stars 65 forks source link

`Coredump.md`: Add support for multiple instances in a coredump #207

Closed fitzgen closed 1 year ago

fitzgen commented 1 year ago

@dschuff PTAL

cc @xtuc

One thing that I noticed is that it seems like the core section isn't really useful anymore: all it does is define an executable-name, which I think was intended to be the module name before, but now we support multiple modules. I left it as-is in this PR but we should discuss whether we want to remove it, change it, or something else.

Fixes #204

fitzgen commented 1 year ago

Gentle ping @dschuff

xtuc commented 1 year ago

@fitzgen naming doesn't make it obvious but the core section is used to describe the process, executable name, arguments, env variables etc. To start, it only contains the executable's name.

fitzgen commented 1 year ago

@fitzgen naming doesn't make it obvious but the core section is used to describe the process, executable name, arguments, env variables etc. To start, it only contains the executable's name.

Wasm itself doesn't really have these concepts, although WASI has them to a degree. I've filed https://github.com/WebAssembly/tool-conventions/issues/209 to further discuss this issue, since it doesn't need to block this PR.

dschuff commented 1 year ago

OK, looks like we've converged on this PR so I'll merge it.