search

WebAssembly / wabt

The WebAssembly Binary Toolkit
Apache License 2.0
6.9k stars 702 forks source link

Fix bug in wasm2c's tail-call optimization code generation #2420

Closed squk closed 6 months ago

squk commented 6 months ago

@sbc100 I updated the failing test case. But it looks like we should also have test cases to ensure the golden files can compile as well, which would've prevented this.

sbc100 commented 6 months ago

@sbc100 I updated the failing test case. But it looks like we should also have test cases to ensure the golden files can compile as well, which would've prevented this.

Indeed, no need to block this change on that though.

keithw commented 6 months ago

Hmm, I realize this means there are zero upstream tail-call tests that use imports at all, much less attempt to tail-call them. There probably should be some. :-/