search

WebAssembly / wabt

The WebAssembly Binary Toolkit
Apache License 2.0
6.78k stars 691 forks source link

Fix 2nd argument's type definition of some f32/f64 opcodes in opcde.def #2434

Closed tianstcht closed 3 months ago

tianstcht commented 3 months ago

The 2nd argument's type ​​​​of these opcodes are different from the wasm spec

sbc100 commented 3 months ago

It looks like its the second argument type you are changing here, not the return type? Other than updating the PR description to reflect that this lgtm! Thanks. Kind of shame that this isn't pragmatically verified somehow/somewhere in wabt.

tianstcht commented 3 months ago

It looks like its the second argument type you are changing here, not the return type? Other than updating the PR description to reflect that this lgtm! Thanks. Kind of shame that this isn't pragmatically verified somehow/somewhere in wabt.

Thank you, it's my typo, now it has been changed.