search

WebAssembly / wasi-nn

Neural Network proposal for WASI
448 stars 35 forks source link

Convert wasi-nn to the new proposal template #17

Closed abrown closed 2 years ago

abrown commented 2 years ago

This includes a re-factoring of the API to WIT (previously WITX). No API changes are intended here; documentation has been improved and updated. The wasi-nn.abi.md file was generated with the following sequence of commands:

git clone https://github.com/WebAssembly/wasi-tools
cd wasi-tools/wit-abi
cargo build
target/debug/wit-abi <path to wasi-nn directory>
abrown commented 2 years ago

cc: @radu-matei, this builds on the WIT syntax you created over in https://github.com/fermyon/wasi-experimental-toolkit/blob/main/wit/ephemeral/wasi-nn.wit but with some changes here and there to map to the new WASI proposal template.

radu-matei commented 2 years ago

Is the .wit file supposed to be in this PR as well?

This looks GREAT! Thanks!

abrown commented 2 years ago

Is the .wit file supposed to be in this PR as well?

I think the new "right way" (at least from looking around) was to put it into a wasi-nn.wit.md file with associated comments. Do you need a comment-less version in a .wit file for what you are working on?