WebAssembly / wasi-nn

Neural Network proposal for WASI
471 stars 36 forks source link

Fix `get-output` return type #29

Closed abrown closed 2 years ago

abrown commented 2 years ago

In porting the WITX definition to WIT, I inadvertently changed the return type of get-output. @yamt identified this issue in #24--thank you! This change fixes the return type to the original type, tensor-data. (In the future, it may be interesting to return more information about the tensor, but that can be a separate issue).

yamt commented 2 years ago

is it worth to fix this alone? i mean, even with this fix, the witx version and the wit version don't seem to be api/abi compatible anyway as you can see in https://github.com/bytecodealliance/wasmtime/pull/4451