search

WebAssembly / wasi-sdk

WASI-enabled WebAssembly C/C++ toolchain
Apache License 2.0
1.23k stars 177 forks source link

Retire clang_version #451

Closed yamt closed 1 month ago

yamt commented 2 months ago

Note: this makes the "install" target install the compiler rt into the compiler's runtime directory. IMO, it's what "install" is supposed to do. If you want to avoid modifing the runtime directory for some reasons, you can still do "dist" without "install".

alexcrichton commented 1 month ago

Personally I think that "install" should only ever modify things under CMAKE_INSTALL_PREFIX by default. Having an option to modify the host compiler's sysroot seems reasonable, but I don't think by default this should modify the host compiler's sysroot.

yamt commented 1 month ago

Personally I think that "install" should only ever modify things under CMAKE_INSTALL_PREFIX by default. Having an option to modify the host compiler's sysroot seems reasonable, but I don't think by default this should modify the host compiler's sysroot.

i tend to disagree. but i pushed a change to avoid modifying the host compiler's resource dir.