Use MSVC for the Windows toolchain instead of MinGW

WebAssembly / wasi-sdk

WASI-enabled WebAssembly C/C++ toolchain

Apache License 2.0

1.27k stars 190 forks source link

Use MSVC for the Windows toolchain instead of MinGW #456

Closed alexcrichton closed 3 months ago

alexcrichton commented 3 months ago

Explicitly use MSVC to avoid the runtime dependencies that the default toolchain CMake is using is bringing in.

Closes #454

alexcrichton commented 3 months ago

Got a successful CI run, but I'm going to rerun CI to confirm that caching makes it so the next run isn't 2 hours. Afterwards I'll download this on a windows machine and test that things work as expected.

pavelsavara commented 3 months ago

I was able to compile dotnet/mono using the artifact from this PR on my local windows

alexcrichton commented 3 months ago

The "cached build" took 2+ hours so I'm going to try to dig in to why ccache isn't working.

alexcrichton commented 3 months ago

Hm on a new commit it worked with a ~20m build time, similar to today. Given that I think this is ok, so I'm going to merge.