search

WebAssembly / wasi-sockets

WASI API proposal for managing sockets
Other
248 stars 22 forks source link

Make `ipv6-only` the default and remove the ability to configure it. #93

Closed badeend closed 10 months ago

badeend commented 10 months ago

Currently, the spec doesn't mention anything about the default value of ipv6-only. This PR changes that to be true, because that's universally supported.

This requires a change in wasmtime. JCO should be good to go as libuv does this by default.

Additionally, this PR removes the ability to enable dual-stack sockets (ipv6-only==false) altogether as the OS-support is questionable:

This removal does not preclude us from adding an advanced option in the future to opt back in to this.

pchickey commented 10 months ago

This is a breaking wit change, but I've checked in with various stakeholders and we all agree that this both the right change to make for the spec, and a very minor breakage to accommodate in all implementations we know of.

The alternative to making this change to remove the setter and getter is to document that the getter always returns true and the setter traps when given false, which doesnt seem like an ideal outcome.

Therefore, I'd like to land this change ASAP and then cut new RCs.