search

WebAssembly / wasi-testsuite

WASI Testsuite
Apache License 2.0
53 stars 21 forks source link

Add WasmEdge adapter #64

Closed harry900831 closed 1 year ago

harry900831 commented 1 year ago

WasmEdge is going to add this test suite in the CI and we will maintain our adapter in our repository.

We're comfortable with either decision: adding the adapter here or use the adapter in our repository to run daily runtime validation.

This may be merged after the fixes are resolved on WasmEdge https://github.com/WasmEdge/WasmEdge/issues/2249.

codefromthecrypt commented 1 year ago

@harry900831 there seems a debate about whether or not this should be allowed at all going on in this thread. you can comment if you like https://github.com/WebAssembly/wasi-testsuite/pull/55#issuecomment-1454253271

loganek commented 1 year ago

@harry900831 thanks a lot for your change. Would it be possible to host your adapter in the WasmEdge repository, just like we do for Wazero: https://github.com/WebAssembly/wasi-testsuite/pull/55?

Thanks

harry900831 commented 1 year ago

Done. The adaptor should be in WasmEdge's repo after this be merged: https://github.com/WasmEdge/WasmEdge/pull/2328. Thanks!

yamt commented 1 year ago

i guess you need a rebase after wazero commit.

loganek commented 1 year ago

Do apologize for the delay. The change looks good to me, thanks.