search

WebAssembly / wasm-c-api

Wasm C API prototype
Apache License 2.0
534 stars 77 forks source link

C API: u8 in Rust corresponds to unsigned char* in C #179

Open dannywillems opened 1 year ago

dannywillems commented 1 year ago

Related to https://github.com/wasmerio/wasmer/pull/3597/

rossberg commented 1 year ago

Wouldn't it be more appropriate to fix the typedef for byte_t instead?

dannywillems commented 1 year ago

I thought about it. byte_t is used in different places, and I didn't know if it would impact a lot of the codebase/users.

If you confirm it is fine, I agree with changing.

syrusakbary commented 1 year ago

@rossberg thoughts on this 👆?

rossberg commented 1 year ago

Yes, confirmed. Thanks. :)

syrusakbary commented 1 year ago

@dannywillems should we update then the byte_t typedef so this PR can be merged?