This is implemented using std::strcpy, which stops copying when it encounters \0. It seems like more often than not, it's used to hold bytes of a Wasm binary (as a vec<byte_t>). But Wasm binaries start with \0asm, so nothing will be copied.
I'm not sure if there are other specializations where stopping at the first \0 makes sense. Considering that we already have vec::make(std::string), perhaps vec::make_nt isn't so helpful and we may want to consider removing it.
I refer to
vec<T>::make_nt
:https://github.com/WebAssembly/wasm-c-api/blob/2ce1367c9d1271c83fb63bef26d896a2f290cd23/include/wasm.hh#L154-L158
This is implemented using
std::strcpy
, which stops copying when it encounters\0
. It seems like more often than not, it's used to hold bytes of a Wasm binary (as avec<byte_t>
). But Wasm binaries start with\0asm
, so nothing will be copied.I'm not sure if there are other specializations where stopping at the first
\0
makes sense. Considering that we already havevec::make(std::string)
, perhapsvec::make_nt
isn't so helpful and we may want to consider removing it.https://github.com/WebAssembly/wasm-c-api/issues/149 is also related.