WebAudio / web-audio-api

The Web Audio API v1.0, developed by the W3C Audio WG
https://webaudio.github.io/web-audio-api/
Other
1.05k stars 167 forks source link

Restore changes accidentally reverted in bikeshed conversion #2155

Closed karlt closed 4 years ago

karlt commented 4 years ago

One such change is the "Spec document unloading" PR, which was merged to index.html November 2017, for issue https://github.com/WebAudio/web-audio-api/issues/1139

Mention of unload was removed from index.html in the Bikeshed conversion commit, which was merged March 2018, and there was no mention in the new index.bs.

padenot commented 4 years ago

Telconf decision: put this one back, and try to find a way to find what else has been missed.

padenot commented 4 years ago

I'm going to rebase my old PR on the current text, and find paths that create promises that have been added since then, to add then to the [[pending promises]] array.

This must have been missed when re-basing in-flight PRs in between starting and merging the Bikeshed conversion work.

padenot commented 4 years ago

This has been sorted out in #2166. Hopefully it was the only one.

karlt commented 4 years ago

Thank you for fixing that.

I used w3m to convert to text the versions of index.html before and after the bikeshed and then ran patdiff -html <(sed s/’/\'/g index.c70964.w3m) <(sed s/’/\'/g index.e8f64d.w3m).

The key changes that came with the bikeshed conversion are listed below. I didn't find anything major that has been missed.

I assume these changes were intended:

These changes have since been corrected:

These have not been corrected, but don't seem significant:

This is now irrelevant because the state property no longer exists:

-|the node. The flag change is propagated by queueing a task on the control
-|thread to update the corresponding AudioWorkletNode's state property
-|accordingly.
+|the node. To propagate the flag change queue a task on the control thread to
+|update the corresponding AudioWorkletNode's state property accordingly.