search

WebAudio / web-audio-api

The Web Audio API v1.0, developed by the W3C Audio WG
https://webaudio.github.io/web-audio-api/
Other
1.05k stars 166 forks source link

Fix compression curve diagram #2277

Closed padenot closed 3 years ago

padenot commented 3 years ago

The knee comes after the threshold, and is added to it, so the soft knee starts at the treshold.

padenot commented 3 years ago

https://github.com/WebAudio/web-audio-api/pull/2277/files?short_path=7b72c9b#diff-7b72c9b801345c6cd8c520be21197c028322286e8ba7ca8bd0f55ae28afc26bb shows the difference.

rtoy commented 3 years ago

Not sure what's up with bikeshed. Some intermittent data issue?

padenot commented 3 years ago

Looks good. What did you use to create this image? Should the source be in the repo? We've have the source Graffle files for all of the images that used Graffle.

I used Inkscape, an SVG editor that is free software. The source is the file itself :-).

Unclear what's up with bikeshed.

rtoy commented 3 years ago

Looks good. What did you use to create this image? Should the source be in the repo? We've have the source Graffle files for all of the images that used Graffle.

I used Inkscape, an SVG editor that is free software. The source is the file itself :-). Heh. Ok.

Unclear what's up with bikeshed. Yeah. I don't have this problem when I build locally. I even updated my copy of bikeshed to the latest version just now.

padenot commented 3 years ago

Same, but I also retriggered the travis build, and it still fails.