search

WebAudio / web-audio-api

The Web Audio API v1.0, developed by the W3C Audio WG
https://webaudio.github.io/web-audio-api/
Other
1.05k stars 166 forks source link

Replace "queue a task" with "queue a media element task" #2307

Closed hoch closed 3 years ago

hoch commented 3 years ago

Fixes #2095.

This replaces all instances of "queue a task" with "queue a media element task" to clarify the task source. See https://github.com/WebAudio/web-audio-api/issues/2095#issuecomment-796905208.

Preview | Diff

hoch commented 3 years ago

We can easily do "Each BaseAudioContext has a unique media element event task source."

hoch commented 3 years ago

@padenot Here's my reasoning behind this change: https://github.com/WebAudio/web-audio-api/issues/2095#issuecomment-796616784

I don't think we want to create a new BaseAudioContext Task Source just for this reason.

hoch commented 3 years ago

@padenot Is there anything else needs to be done here?

hoch commented 3 years ago

Thanks for the review, @padenot!