search

WebAudio / web-audio-api

The Web Audio API v1.0, developed by the W3C Audio WG
https://webaudio.github.io/web-audio-api/
Other
1.04k stars 166 forks source link

WebIDL no longer defines "present" #2338

Closed svgeesus closed 3 years ago

svgeesus commented 3 years ago

Describe the issue

There are a bunch of links 

<a href="https://heycam.github.io/webidl/#dfn-present">present</a>

but WebIDL no longer defines this so the link is broken. I traced it to this issue where they defer to the infra definition map-exists. Although the related pull request didn't seem to remove that term :(

So I believe this should be

<a href="https://infra.spec.whatwg.org/#map-exists">present</a>

I have made this change in the Proposed Rec, as we are nt allowed to have broken links. If there is a better link, we have like 24 hours to update it.

rtoy commented 3 years ago

The first occurrence I looked at is Step 2 of the ConvolverNode constructor:

If buffer is present, set the buffer attribute to its value.

Both buffer link to the buffer attribute. Perhaps the first buffer is meant to be the buffer member of the ConvolverOptions dictionary? Otherwise, I can't make sense of this sentence.

But I think the link to map-exists is the right one for rest of the convolver constructor algorithm; they all talk about a dictionary member being "present" in the options dictionary. So "map-exists" makes sense.

Since you already made the change for the PR, I'm not sure how to proceed here.

padenot commented 3 years ago

Probably back-port here, and we're good, no ?