search

WebAudio / web-audio-api

The Web Audio API v1.0, developed by the W3C Audio WG
https://webaudio.github.io/web-audio-api/
Other
1.04k stars 165 forks source link

RangeError is thrown only for negative cancelTime #2352

Closed rtoy closed 2 years ago

rtoy commented 3 years ago

Fixes WebAudio/web-audio-api-v2#127 by removing the text that says a RangeError is also thrown for non-finite values. That's not possible because the type of cancelTime is double, not unrestricted double. Non-finite values are handled at a higher level before these methods even see the number.

Preview | Diff

rtoy commented 3 years ago

@svgeesus My guess on how a candidate correction would work. I just copied fixup.js from https://github.com/w3c/tr-design/issues that is mentioned in http://fantasai.inkedblade.net/style/design/w3c-restyle/2020/readme.

I have no idea if that's the right thing to do or not. Also, for the id, I used c127, where 127 is the issue number of the thing we're fixing.

And finally, the toggle buttons change both the text in cancelAndHoldAtTime and cancelScheduledValues. Perhaps that's not the best, even though it is one issue.

padenot commented 3 years ago

The Web Audio API looks good, in any case.

rtoy commented 3 years ago

There are no insertions so no <ins>. But there are deletions marked by <del>. You have to scroll way over to the right to see it where we delete the phrase "or is not a finite number".

I see now that we don't need to include fixup.js in our repo. We can just load it up from w3c.org as you did in the audio eq cookbook note.

rtoy commented 3 years ago

Need #2363 to be merged first now since that PR has all the bits needed, including adding a change log entry

hoch commented 2 years ago

TODO: needs rebase.

padenot commented 2 years ago

@hoch: I've rebased this while I was at it.