search

WebAudio / web-audio-api

The Web Audio API v1.0, developed by the W3C Audio WG
https://webaudio.github.io/web-audio-api/
Other
1.05k stars 166 forks source link

Fix #2359: Fix typo in VUMeterNode #2360

Closed rtoy closed 3 years ago

rtoy commented 3 years ago

The typo is marked as a candidate correction, and linked to #2359 for easy tracking. The id is "c2359" where "c" stands for "correction", and "2359" is the corresponding V1 issue number. This makes it easy to create unique ids for the links necessary for the correction.

Preview | Diff

rtoy commented 3 years ago

See also https://github.com/WebAudio/web-audio-api/wiki/UpdatingLivingStandard for the approach I've taken here.

We will probably want to discuss that page at the next meeting to see if this is really how we want to do this.

rtoy commented 3 years ago

fixup.js was needed because that's how the candidate corrections/additions are styled.

However, I just found out that we don't need to include this anymore; bikeshed automatically adds this now.

rtoy commented 3 years ago

"get a reference to the buffer source" appears to be gone. I'll have to figure out what happened between yesterday and today, but I can reproduce this locally and I had updated bikeshed just a bit before.

rtoy commented 3 years ago

The updated bikeshed has the new WebIDL buffer primitives mentioned in #2361.

This PR should probably be landed after #2363.

svgeesus commented 3 years ago

These candidate corrections should all be listed in a new "Changes since the Recommendation of 17 June 2021" section, which also makes it easy to find them. (This is a general comment, nt a blocker on this specific fix)

padenot commented 3 years ago

I've added the bits @svgeesus talks about, this is good for merging.