WebAudio / web-audio-api

The Web Audio API v1.0, developed by the W3C Audio WG
https://webaudio.github.io/web-audio-api/
Other
1.04k stars 165 forks source link

Minor editorial changes in output device selection (sinkId) #2523

Closed hoch closed 1 year ago

hoch commented 1 year ago

PTAL - this PR has no functional changes.

The summary:

Expand the equality clause into two specific cases in the AudioContext constructor algorithm: now it has the exact same language with the AudioContext.setSinkId() method. Remove redundant validation step: the WebIDL is thorough enough to throw a TypeError when an invalid enum is given as an argument. We don't need to check the type value within the Web Audio API implementation.


:boom: Error: 500 Internal Server Error :boom:

PR Preview failed to build. (Last tried on Nov 2, 2022, 5:47 PM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs. :link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2FWebAudio%2Fweb-audio-api%2F527abc391ee256872be6564d3b5425a11635ed35%2Findex.bs&force=1&md-warning=not%20ready) ``` 500 Internal Server Error

Internal Server Error

The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator at [no address given] to inform them of the time this error occurred, and the actions you performed just before this error.

More information about this error may be available in the server error log.


Apache/2.4.10 (Debian) Server at api.csswg.org Port 443
``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20WebAudio/web-audio-api%232523.)._