search

WebBluetoothCG / demos

Demo applications showing off Web Bluetooth
https://webbluetoothcg.github.io/demos/
Apache License 2.0
624 stars 188 forks source link

playbulb-candle: Fix nit in sw #52

Closed beaufortfrancois closed 8 years ago

beaufortfrancois commented 8 years ago

As discussed in https://github.com/GoogleChrome/samples/pull/380/files/1c95a4df94a7cf34d7081d655c7c614ed4d02454#r68593116, this PR removes confusing check in SW. TBR=@scheib

scheib commented 8 years ago

LGTM

scheib commented 8 years ago

er... when checking out https://github.com/WebBluetoothCG/demos/pull/51 I noticed that I couldn't see the update. I had to manually clear the cache for the site before it would appear. I also notice that https://bugs.chromium.org/p/chromium/issues/detail?id=601095 is fixed now. So, perhaps it is best to leave the waitUntil in place?

beaufortfrancois commented 8 years ago

Thanks! I've addressed your feedback at https://github.com/WebBluetoothCG/demos/pull/53