Kotlin - Githubissues

WebClub-NITK / Hacktoberfest-2k20

Repository for Hacktoberfest 2020 Meetup at NITK Surathkal

14 stars 53 forks source link

Kotlin #111

Closed LazybuddyNK closed 4 years ago

LazybuddyNK commented 4 years ago

Resolves Issue #88

Description

Finding the IPv4 class using Kotlin.

Technical Specifications

Screenshots (if required)

How to run

Open the code in IntelliJ IDEA, or in vs code(install the required dependencies)

Checklist

[x] Code compiles correctly.
[x] Changes are tested properly.
[x] Added the README / documentation, if necessary.
[x] Followed the Contributing guidelines.
[x] Resolved merge conflicts, if any.

LazybuddyNK commented 4 years ago

If there was any mistake from my side please tell. This was my very first pull request. Thank you!!

krithikvaidya commented 4 years ago

Hey @LazybuddyNK, good job. A few points though - you need to check for invalid inputs too, like it was mentioned in the issue. Also, add the instructions to run in the "How to run" section of the PR description. And if you change #<88> to #88 in the first line of your PR description, it'll automatically link to the issue.

LazybuddyNK commented 4 years ago

Hey @LazybuddyNK, good job. A few points though - you need to check for invalid inputs too, like it was mentioned in the issue. Also, add the instructions to run in the "How to run" section of the PR description. And if you change #<88> to #88 in the first line of your PR description, it'll automatically link to the issue.

Okay, I will do whatever u said. and thanks for the feedback