WebClub-NITK / old_website

Old Website of the Web Enthusiasts Club NITK listing all the members and projects undertaken by the club over the years. New website available at https://webclub.nitk.ac.in

https://webclub.nitk.ac.in/old_website/

MIT License

7 stars 25 forks source link

Create events page #26

Closed utkarsh23 closed 6 years ago

utkarsh23 commented 6 years ago

Closes #17

Desktop View

webclub_desktop

Mobile View

webclub_mobile Do not merge this PR just yet.

[x] Create Basic Events Page
[x] Sort events by date
[x] Create modal for event description
[x] Add transitions for modals

sbshah97 commented 6 years ago

FOr fututre references, if you are still working on your PR, add a WIP in the PR Title!

Hrily commented 6 years ago

@utkarsh23

A slight left margin for events on mobile view would be great.
Make title of the event description view bold
The background of Events was supposed to be Gray, @salman-bhai What do you say, should it be gray or image. I prefer gray.

The rest is perfect 👍 Good Job

sbshah97 commented 6 years ago

I prefer image @Hrily. Always looks better

Hrily commented 6 years ago

@salman-bhai Okay 👍

Hrily commented 6 years ago

@utkarsh23 We need to have a Year scroller as well. See Programming events PR for the design

utkarsh23 commented 6 years ago

Alright 👍

sbshah97 commented 6 years ago

@Hrily anything else that's needed here?

utkarsh23 commented 6 years ago

@salman-bhai just a few more changes, I'll try to wrap it up by tonight

sbshah97 commented 6 years ago

Alright.

utkarsh23 commented 6 years ago

Changes made, you can review this now

sbshah97 commented 6 years ago

Looks good from my side, let's wait for @Hrily 's review!

Hrily commented 6 years ago

Please check the font size Also remove the Events background color