search

WebControlCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
3 stars 4 forks source link

New Motor Contorl Shield Integration #12

Closed ghost closed 3 years ago

ghost commented 3 years ago

What does this pull request do?

The intent of this PR is to merge changes made to the MaslowCNC-master firmware via Pull Requests #550 and #551 into the WebControl-master. The requested changes will allow for the recognition of a v1.5 and v1.8 motor control shield based on the TB6643KQ Motor Driver chip. Please note that the v1.5 board is hardware that is currently being offered through East Bay Source while the v1.8 board is a design intended to be released as an open source, Maslow Community Garden project. The version 1.8 shield design is intneded as an alternative to the TLE shield designs that are currently available.

Does this firmware change affect kinematics or any part of the calibration process?

No. Current kinematics should be un-affected by this change

How can this pull request be tested?

The code changes have been previously tested against an alpha and beta version of the board design. The current testing was conducted using a release version of the board with a fork of the MaslowCNC-master firmware. Testing proved the functionality of the board over several "long duaration" test cuts and operation. A larger sample of users will be needed to test long term durability of the chips and board design. The release to the Community Garden and adoption by a base should provide sufficient functional testing of the design. As the functional testing with the MaslowCNC-master has proven successfull, this request seeks to merge those changes into the WebControl-master as well.

ghost commented 3 years ago

I closed this PR in order to re-submit.